Mercurial > hg > Members > kono > nitros9-code

changeset 75:ce04e3883dec

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Fixed I$Detach Static Storage Wipeout Bug
author boisy
date Sun, 12 May 2002 03:18:14 +0000
parents e3956c6fd78b
children 6f72b77131c0
files level1/modules/ioman.asm
diffstat 1 files changed, 15 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/level1/modules/ioman.asm	Sun May 12 03:14:31 2002 +0000
+++ b/level1/modules/ioman.asm	Sun May 12 03:18:14 2002 +0000
@@ -6,6 +6,8 @@
 * Ed.    Comments                                       Who YY/MM/DD
 * ------------------------------------------------------------------
 * 11     Tandy/Microware original version
+* 12     I/O Queue sort bug and I$Attach static storage BGP 02/05/11
+*        premature deallocation bug fixed
 
          nam   IOMan
          ttl   OS-9 Level One V2 I/O Manager module
@@ -17,9 +19,9 @@
 tylg     set   Systm+Objct
 atrv     set   ReEnt+rev
 rev      set   $01
-* edition $0B = Stock OS-9 Level One Vr. 2.00 IOMan
-* edition $0C = IO Queue sort bug fixed
-edition  equ   $0C
+* edition 11 = Stock OS-9 Level One Vr. 2.00 IOMan
+* edition 12 = IO Queue sort bug fixed, IAttach bug fixed
+edition  equ   12
 
          mod   eom,name,tylg,atrv,IOManEnt,size
 
@@ -294,17 +296,26 @@
 
 IDetach  ldu   R$U,u
          ldx   V$DESC,u
+         IFEQ  edition-11
+* Note:  the following lines constitute a bug that can, in certain
+*        circumstances, wipe out a device's static storage out from
+*        underneath it.
          ldb   V$USRS,u                get user count
          bne   L0218                   branch if not zero
          pshs  u,b
          ldu   V$STAT,u
          pshs  u
          bra   L0254
+         ELSE
+         tst   V$USRS,u
+         beq   IDetach2
+         ENDC
 L0218    lda   #255
          cmpa  V$USRS,u                255 users?
          lbeq  L0283                   branch if so
          dec   V$USRS,u                else dec user count
          lbne  L0271                   branch if dec not 0
+IDetach2
          ldx   <D.Init
          ldb   DevCnt,x
          pshs  u,b
@@ -926,7 +937,7 @@
          bcs   L070F
          ldb   P$Age,u
 
-         ifeq  edition-$0B
+         ifeq  edition-11
 
 * Note:  the following line is a bug
          cmpd  P$Age,y