annotate clang-tools-extra/clangd/Quality.cpp @ 173:0572611fdcc8 llvm10 llvm12

reorgnization done
author Shinji KONO <kono@ie.u-ryukyu.ac.jp>
date Mon, 25 May 2020 11:55:54 +0900
parents 1d019706d866
children 2e18cbf3894f
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
150
anatofuz
parents:
diff changeset
1 //===--- Quality.cpp ---------------------------------------------*- C++-*-===//
anatofuz
parents:
diff changeset
2 //
anatofuz
parents:
diff changeset
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
anatofuz
parents:
diff changeset
4 // See https://llvm.org/LICENSE.txt for license information.
anatofuz
parents:
diff changeset
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
anatofuz
parents:
diff changeset
6 //
anatofuz
parents:
diff changeset
7 //===----------------------------------------------------------------------===//
anatofuz
parents:
diff changeset
8
anatofuz
parents:
diff changeset
9 #include "Quality.h"
anatofuz
parents:
diff changeset
10 #include "AST.h"
anatofuz
parents:
diff changeset
11 #include "FileDistance.h"
anatofuz
parents:
diff changeset
12 #include "SourceCode.h"
anatofuz
parents:
diff changeset
13 #include "URI.h"
anatofuz
parents:
diff changeset
14 #include "index/Symbol.h"
anatofuz
parents:
diff changeset
15 #include "clang/AST/ASTContext.h"
anatofuz
parents:
diff changeset
16 #include "clang/AST/Decl.h"
anatofuz
parents:
diff changeset
17 #include "clang/AST/DeclCXX.h"
anatofuz
parents:
diff changeset
18 #include "clang/AST/DeclTemplate.h"
anatofuz
parents:
diff changeset
19 #include "clang/AST/DeclVisitor.h"
anatofuz
parents:
diff changeset
20 #include "clang/Basic/CharInfo.h"
anatofuz
parents:
diff changeset
21 #include "clang/Basic/SourceManager.h"
anatofuz
parents:
diff changeset
22 #include "clang/Sema/CodeCompleteConsumer.h"
anatofuz
parents:
diff changeset
23 #include "llvm/ADT/ArrayRef.h"
anatofuz
parents:
diff changeset
24 #include "llvm/ADT/SmallString.h"
anatofuz
parents:
diff changeset
25 #include "llvm/ADT/SmallVector.h"
anatofuz
parents:
diff changeset
26 #include "llvm/ADT/StringExtras.h"
anatofuz
parents:
diff changeset
27 #include "llvm/ADT/StringRef.h"
anatofuz
parents:
diff changeset
28 #include "llvm/Support/Casting.h"
anatofuz
parents:
diff changeset
29 #include "llvm/Support/FormatVariadic.h"
anatofuz
parents:
diff changeset
30 #include "llvm/Support/MathExtras.h"
anatofuz
parents:
diff changeset
31 #include "llvm/Support/raw_ostream.h"
anatofuz
parents:
diff changeset
32 #include <algorithm>
anatofuz
parents:
diff changeset
33 #include <cmath>
anatofuz
parents:
diff changeset
34
anatofuz
parents:
diff changeset
35 namespace clang {
anatofuz
parents:
diff changeset
36 namespace clangd {
anatofuz
parents:
diff changeset
37 static bool isReserved(llvm::StringRef Name) {
anatofuz
parents:
diff changeset
38 // FIXME: Should we exclude _Bool and others recognized by the standard?
anatofuz
parents:
diff changeset
39 return Name.size() >= 2 && Name[0] == '_' &&
anatofuz
parents:
diff changeset
40 (isUppercase(Name[1]) || Name[1] == '_');
anatofuz
parents:
diff changeset
41 }
anatofuz
parents:
diff changeset
42
anatofuz
parents:
diff changeset
43 static bool hasDeclInMainFile(const Decl &D) {
anatofuz
parents:
diff changeset
44 auto &SourceMgr = D.getASTContext().getSourceManager();
anatofuz
parents:
diff changeset
45 for (auto *Redecl : D.redecls()) {
anatofuz
parents:
diff changeset
46 if (isInsideMainFile(Redecl->getLocation(), SourceMgr))
anatofuz
parents:
diff changeset
47 return true;
anatofuz
parents:
diff changeset
48 }
anatofuz
parents:
diff changeset
49 return false;
anatofuz
parents:
diff changeset
50 }
anatofuz
parents:
diff changeset
51
anatofuz
parents:
diff changeset
52 static bool hasUsingDeclInMainFile(const CodeCompletionResult &R) {
anatofuz
parents:
diff changeset
53 const auto &Context = R.Declaration->getASTContext();
anatofuz
parents:
diff changeset
54 const auto &SourceMgr = Context.getSourceManager();
anatofuz
parents:
diff changeset
55 if (R.ShadowDecl) {
anatofuz
parents:
diff changeset
56 if (isInsideMainFile(R.ShadowDecl->getLocation(), SourceMgr))
anatofuz
parents:
diff changeset
57 return true;
anatofuz
parents:
diff changeset
58 }
anatofuz
parents:
diff changeset
59 return false;
anatofuz
parents:
diff changeset
60 }
anatofuz
parents:
diff changeset
61
anatofuz
parents:
diff changeset
62 static SymbolQualitySignals::SymbolCategory categorize(const NamedDecl &ND) {
anatofuz
parents:
diff changeset
63 if (const auto *FD = dyn_cast<FunctionDecl>(&ND)) {
anatofuz
parents:
diff changeset
64 if (FD->isOverloadedOperator())
anatofuz
parents:
diff changeset
65 return SymbolQualitySignals::Operator;
anatofuz
parents:
diff changeset
66 }
anatofuz
parents:
diff changeset
67 class Switch
anatofuz
parents:
diff changeset
68 : public ConstDeclVisitor<Switch, SymbolQualitySignals::SymbolCategory> {
anatofuz
parents:
diff changeset
69 public:
anatofuz
parents:
diff changeset
70 #define MAP(DeclType, Category) \
anatofuz
parents:
diff changeset
71 SymbolQualitySignals::SymbolCategory Visit##DeclType(const DeclType *) { \
anatofuz
parents:
diff changeset
72 return SymbolQualitySignals::Category; \
anatofuz
parents:
diff changeset
73 }
anatofuz
parents:
diff changeset
74 MAP(NamespaceDecl, Namespace);
anatofuz
parents:
diff changeset
75 MAP(NamespaceAliasDecl, Namespace);
anatofuz
parents:
diff changeset
76 MAP(TypeDecl, Type);
anatofuz
parents:
diff changeset
77 MAP(TypeAliasTemplateDecl, Type);
anatofuz
parents:
diff changeset
78 MAP(ClassTemplateDecl, Type);
anatofuz
parents:
diff changeset
79 MAP(CXXConstructorDecl, Constructor);
anatofuz
parents:
diff changeset
80 MAP(CXXDestructorDecl, Destructor);
anatofuz
parents:
diff changeset
81 MAP(ValueDecl, Variable);
anatofuz
parents:
diff changeset
82 MAP(VarTemplateDecl, Variable);
anatofuz
parents:
diff changeset
83 MAP(FunctionDecl, Function);
anatofuz
parents:
diff changeset
84 MAP(FunctionTemplateDecl, Function);
anatofuz
parents:
diff changeset
85 MAP(Decl, Unknown);
anatofuz
parents:
diff changeset
86 #undef MAP
anatofuz
parents:
diff changeset
87 };
anatofuz
parents:
diff changeset
88 return Switch().Visit(&ND);
anatofuz
parents:
diff changeset
89 }
anatofuz
parents:
diff changeset
90
anatofuz
parents:
diff changeset
91 static SymbolQualitySignals::SymbolCategory
anatofuz
parents:
diff changeset
92 categorize(const CodeCompletionResult &R) {
anatofuz
parents:
diff changeset
93 if (R.Declaration)
anatofuz
parents:
diff changeset
94 return categorize(*R.Declaration);
anatofuz
parents:
diff changeset
95 if (R.Kind == CodeCompletionResult::RK_Macro)
anatofuz
parents:
diff changeset
96 return SymbolQualitySignals::Macro;
anatofuz
parents:
diff changeset
97 // Everything else is a keyword or a pattern. Patterns are mostly keywords
anatofuz
parents:
diff changeset
98 // too, except a few which we recognize by cursor kind.
anatofuz
parents:
diff changeset
99 switch (R.CursorKind) {
anatofuz
parents:
diff changeset
100 case CXCursor_CXXMethod:
anatofuz
parents:
diff changeset
101 return SymbolQualitySignals::Function;
anatofuz
parents:
diff changeset
102 case CXCursor_ModuleImportDecl:
anatofuz
parents:
diff changeset
103 return SymbolQualitySignals::Namespace;
anatofuz
parents:
diff changeset
104 case CXCursor_MacroDefinition:
anatofuz
parents:
diff changeset
105 return SymbolQualitySignals::Macro;
anatofuz
parents:
diff changeset
106 case CXCursor_TypeRef:
anatofuz
parents:
diff changeset
107 return SymbolQualitySignals::Type;
anatofuz
parents:
diff changeset
108 case CXCursor_MemberRef:
anatofuz
parents:
diff changeset
109 return SymbolQualitySignals::Variable;
anatofuz
parents:
diff changeset
110 case CXCursor_Constructor:
anatofuz
parents:
diff changeset
111 return SymbolQualitySignals::Constructor;
anatofuz
parents:
diff changeset
112 default:
anatofuz
parents:
diff changeset
113 return SymbolQualitySignals::Keyword;
anatofuz
parents:
diff changeset
114 }
anatofuz
parents:
diff changeset
115 }
anatofuz
parents:
diff changeset
116
anatofuz
parents:
diff changeset
117 static SymbolQualitySignals::SymbolCategory
anatofuz
parents:
diff changeset
118 categorize(const index::SymbolInfo &D) {
anatofuz
parents:
diff changeset
119 switch (D.Kind) {
anatofuz
parents:
diff changeset
120 case index::SymbolKind::Namespace:
anatofuz
parents:
diff changeset
121 case index::SymbolKind::NamespaceAlias:
anatofuz
parents:
diff changeset
122 return SymbolQualitySignals::Namespace;
anatofuz
parents:
diff changeset
123 case index::SymbolKind::Macro:
anatofuz
parents:
diff changeset
124 return SymbolQualitySignals::Macro;
anatofuz
parents:
diff changeset
125 case index::SymbolKind::Enum:
anatofuz
parents:
diff changeset
126 case index::SymbolKind::Struct:
anatofuz
parents:
diff changeset
127 case index::SymbolKind::Class:
anatofuz
parents:
diff changeset
128 case index::SymbolKind::Protocol:
anatofuz
parents:
diff changeset
129 case index::SymbolKind::Extension:
anatofuz
parents:
diff changeset
130 case index::SymbolKind::Union:
anatofuz
parents:
diff changeset
131 case index::SymbolKind::TypeAlias:
173
0572611fdcc8 reorgnization done
Shinji KONO <kono@ie.u-ryukyu.ac.jp>
parents: 150
diff changeset
132 case index::SymbolKind::TemplateTypeParm:
0572611fdcc8 reorgnization done
Shinji KONO <kono@ie.u-ryukyu.ac.jp>
parents: 150
diff changeset
133 case index::SymbolKind::TemplateTemplateParm:
150
anatofuz
parents:
diff changeset
134 return SymbolQualitySignals::Type;
anatofuz
parents:
diff changeset
135 case index::SymbolKind::Function:
anatofuz
parents:
diff changeset
136 case index::SymbolKind::ClassMethod:
anatofuz
parents:
diff changeset
137 case index::SymbolKind::InstanceMethod:
anatofuz
parents:
diff changeset
138 case index::SymbolKind::StaticMethod:
anatofuz
parents:
diff changeset
139 case index::SymbolKind::InstanceProperty:
anatofuz
parents:
diff changeset
140 case index::SymbolKind::ClassProperty:
anatofuz
parents:
diff changeset
141 case index::SymbolKind::StaticProperty:
anatofuz
parents:
diff changeset
142 case index::SymbolKind::ConversionFunction:
anatofuz
parents:
diff changeset
143 return SymbolQualitySignals::Function;
anatofuz
parents:
diff changeset
144 case index::SymbolKind::Destructor:
anatofuz
parents:
diff changeset
145 return SymbolQualitySignals::Destructor;
anatofuz
parents:
diff changeset
146 case index::SymbolKind::Constructor:
anatofuz
parents:
diff changeset
147 return SymbolQualitySignals::Constructor;
anatofuz
parents:
diff changeset
148 case index::SymbolKind::Variable:
anatofuz
parents:
diff changeset
149 case index::SymbolKind::Field:
anatofuz
parents:
diff changeset
150 case index::SymbolKind::EnumConstant:
anatofuz
parents:
diff changeset
151 case index::SymbolKind::Parameter:
173
0572611fdcc8 reorgnization done
Shinji KONO <kono@ie.u-ryukyu.ac.jp>
parents: 150
diff changeset
152 case index::SymbolKind::NonTypeTemplateParm:
150
anatofuz
parents:
diff changeset
153 return SymbolQualitySignals::Variable;
anatofuz
parents:
diff changeset
154 case index::SymbolKind::Using:
anatofuz
parents:
diff changeset
155 case index::SymbolKind::Module:
anatofuz
parents:
diff changeset
156 case index::SymbolKind::Unknown:
anatofuz
parents:
diff changeset
157 return SymbolQualitySignals::Unknown;
anatofuz
parents:
diff changeset
158 }
anatofuz
parents:
diff changeset
159 llvm_unreachable("Unknown index::SymbolKind");
anatofuz
parents:
diff changeset
160 }
anatofuz
parents:
diff changeset
161
anatofuz
parents:
diff changeset
162 static bool isInstanceMember(const NamedDecl *ND) {
anatofuz
parents:
diff changeset
163 if (!ND)
anatofuz
parents:
diff changeset
164 return false;
anatofuz
parents:
diff changeset
165 if (const auto *TP = dyn_cast<FunctionTemplateDecl>(ND))
anatofuz
parents:
diff changeset
166 ND = TP->TemplateDecl::getTemplatedDecl();
anatofuz
parents:
diff changeset
167 if (const auto *CM = dyn_cast<CXXMethodDecl>(ND))
anatofuz
parents:
diff changeset
168 return !CM->isStatic();
anatofuz
parents:
diff changeset
169 return isa<FieldDecl>(ND); // Note that static fields are VarDecl.
anatofuz
parents:
diff changeset
170 }
anatofuz
parents:
diff changeset
171
anatofuz
parents:
diff changeset
172 static bool isInstanceMember(const index::SymbolInfo &D) {
anatofuz
parents:
diff changeset
173 switch (D.Kind) {
anatofuz
parents:
diff changeset
174 case index::SymbolKind::InstanceMethod:
anatofuz
parents:
diff changeset
175 case index::SymbolKind::InstanceProperty:
anatofuz
parents:
diff changeset
176 case index::SymbolKind::Field:
anatofuz
parents:
diff changeset
177 return true;
anatofuz
parents:
diff changeset
178 default:
anatofuz
parents:
diff changeset
179 return false;
anatofuz
parents:
diff changeset
180 }
anatofuz
parents:
diff changeset
181 }
anatofuz
parents:
diff changeset
182
anatofuz
parents:
diff changeset
183 void SymbolQualitySignals::merge(const CodeCompletionResult &SemaCCResult) {
anatofuz
parents:
diff changeset
184 Deprecated |= (SemaCCResult.Availability == CXAvailability_Deprecated);
anatofuz
parents:
diff changeset
185 Category = categorize(SemaCCResult);
anatofuz
parents:
diff changeset
186
anatofuz
parents:
diff changeset
187 if (SemaCCResult.Declaration) {
anatofuz
parents:
diff changeset
188 ImplementationDetail |= isImplementationDetail(SemaCCResult.Declaration);
anatofuz
parents:
diff changeset
189 if (auto *ID = SemaCCResult.Declaration->getIdentifier())
anatofuz
parents:
diff changeset
190 ReservedName = ReservedName || isReserved(ID->getName());
anatofuz
parents:
diff changeset
191 } else if (SemaCCResult.Kind == CodeCompletionResult::RK_Macro)
anatofuz
parents:
diff changeset
192 ReservedName = ReservedName || isReserved(SemaCCResult.Macro->getName());
anatofuz
parents:
diff changeset
193 }
anatofuz
parents:
diff changeset
194
anatofuz
parents:
diff changeset
195 void SymbolQualitySignals::merge(const Symbol &IndexResult) {
anatofuz
parents:
diff changeset
196 Deprecated |= (IndexResult.Flags & Symbol::Deprecated);
anatofuz
parents:
diff changeset
197 ImplementationDetail |= (IndexResult.Flags & Symbol::ImplementationDetail);
anatofuz
parents:
diff changeset
198 References = std::max(IndexResult.References, References);
anatofuz
parents:
diff changeset
199 Category = categorize(IndexResult.SymInfo);
anatofuz
parents:
diff changeset
200 ReservedName = ReservedName || isReserved(IndexResult.Name);
anatofuz
parents:
diff changeset
201 }
anatofuz
parents:
diff changeset
202
anatofuz
parents:
diff changeset
203 float SymbolQualitySignals::evaluate() const {
anatofuz
parents:
diff changeset
204 float Score = 1;
anatofuz
parents:
diff changeset
205
anatofuz
parents:
diff changeset
206 // This avoids a sharp gradient for tail symbols, and also neatly avoids the
anatofuz
parents:
diff changeset
207 // question of whether 0 references means a bad symbol or missing data.
anatofuz
parents:
diff changeset
208 if (References >= 10) {
anatofuz
parents:
diff changeset
209 // Use a sigmoid style boosting function, which flats out nicely for large
173
0572611fdcc8 reorgnization done
Shinji KONO <kono@ie.u-ryukyu.ac.jp>
parents: 150
diff changeset
210 // numbers (e.g. 2.58 for 1M references).
150
anatofuz
parents:
diff changeset
211 // The following boosting function is equivalent to:
anatofuz
parents:
diff changeset
212 // m = 0.06
anatofuz
parents:
diff changeset
213 // f = 12.0
anatofuz
parents:
diff changeset
214 // boost = f * sigmoid(m * std::log(References)) - 0.5 * f + 0.59
anatofuz
parents:
diff changeset
215 // Sample data points: (10, 1.00), (100, 1.41), (1000, 1.82),
anatofuz
parents:
diff changeset
216 // (10K, 2.21), (100K, 2.58), (1M, 2.94)
anatofuz
parents:
diff changeset
217 float S = std::pow(References, -0.06);
anatofuz
parents:
diff changeset
218 Score *= 6.0 * (1 - S) / (1 + S) + 0.59;
anatofuz
parents:
diff changeset
219 }
anatofuz
parents:
diff changeset
220
anatofuz
parents:
diff changeset
221 if (Deprecated)
anatofuz
parents:
diff changeset
222 Score *= 0.1f;
anatofuz
parents:
diff changeset
223 if (ReservedName)
anatofuz
parents:
diff changeset
224 Score *= 0.1f;
anatofuz
parents:
diff changeset
225 if (ImplementationDetail)
anatofuz
parents:
diff changeset
226 Score *= 0.2f;
anatofuz
parents:
diff changeset
227
anatofuz
parents:
diff changeset
228 switch (Category) {
anatofuz
parents:
diff changeset
229 case Keyword: // Often relevant, but misses most signals.
anatofuz
parents:
diff changeset
230 Score *= 4; // FIXME: important keywords should have specific boosts.
anatofuz
parents:
diff changeset
231 break;
anatofuz
parents:
diff changeset
232 case Type:
anatofuz
parents:
diff changeset
233 case Function:
anatofuz
parents:
diff changeset
234 case Variable:
anatofuz
parents:
diff changeset
235 Score *= 1.1f;
anatofuz
parents:
diff changeset
236 break;
anatofuz
parents:
diff changeset
237 case Namespace:
anatofuz
parents:
diff changeset
238 Score *= 0.8f;
anatofuz
parents:
diff changeset
239 break;
anatofuz
parents:
diff changeset
240 case Macro:
anatofuz
parents:
diff changeset
241 case Destructor:
anatofuz
parents:
diff changeset
242 case Operator:
anatofuz
parents:
diff changeset
243 Score *= 0.5f;
anatofuz
parents:
diff changeset
244 break;
anatofuz
parents:
diff changeset
245 case Constructor: // No boost constructors so they are after class types.
anatofuz
parents:
diff changeset
246 case Unknown:
anatofuz
parents:
diff changeset
247 break;
anatofuz
parents:
diff changeset
248 }
anatofuz
parents:
diff changeset
249
anatofuz
parents:
diff changeset
250 return Score;
anatofuz
parents:
diff changeset
251 }
anatofuz
parents:
diff changeset
252
anatofuz
parents:
diff changeset
253 llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
anatofuz
parents:
diff changeset
254 const SymbolQualitySignals &S) {
anatofuz
parents:
diff changeset
255 OS << llvm::formatv("=== Symbol quality: {0}\n", S.evaluate());
anatofuz
parents:
diff changeset
256 OS << llvm::formatv("\tReferences: {0}\n", S.References);
anatofuz
parents:
diff changeset
257 OS << llvm::formatv("\tDeprecated: {0}\n", S.Deprecated);
anatofuz
parents:
diff changeset
258 OS << llvm::formatv("\tReserved name: {0}\n", S.ReservedName);
anatofuz
parents:
diff changeset
259 OS << llvm::formatv("\tCategory: {0}\n", static_cast<int>(S.Category));
anatofuz
parents:
diff changeset
260 return OS;
anatofuz
parents:
diff changeset
261 }
anatofuz
parents:
diff changeset
262
anatofuz
parents:
diff changeset
263 static SymbolRelevanceSignals::AccessibleScope
anatofuz
parents:
diff changeset
264 computeScope(const NamedDecl *D) {
anatofuz
parents:
diff changeset
265 // Injected "Foo" within the class "Foo" has file scope, not class scope.
anatofuz
parents:
diff changeset
266 const DeclContext *DC = D->getDeclContext();
anatofuz
parents:
diff changeset
267 if (auto *R = dyn_cast_or_null<RecordDecl>(D))
anatofuz
parents:
diff changeset
268 if (R->isInjectedClassName())
anatofuz
parents:
diff changeset
269 DC = DC->getParent();
anatofuz
parents:
diff changeset
270 // Class constructor should have the same scope as the class.
anatofuz
parents:
diff changeset
271 if (isa<CXXConstructorDecl>(D))
anatofuz
parents:
diff changeset
272 DC = DC->getParent();
anatofuz
parents:
diff changeset
273 bool InClass = false;
anatofuz
parents:
diff changeset
274 for (; !DC->isFileContext(); DC = DC->getParent()) {
anatofuz
parents:
diff changeset
275 if (DC->isFunctionOrMethod())
anatofuz
parents:
diff changeset
276 return SymbolRelevanceSignals::FunctionScope;
anatofuz
parents:
diff changeset
277 InClass = InClass || DC->isRecord();
anatofuz
parents:
diff changeset
278 }
anatofuz
parents:
diff changeset
279 if (InClass)
anatofuz
parents:
diff changeset
280 return SymbolRelevanceSignals::ClassScope;
anatofuz
parents:
diff changeset
281 // ExternalLinkage threshold could be tweaked, e.g. module-visible as global.
anatofuz
parents:
diff changeset
282 // Avoid caching linkage if it may change after enclosing code completion.
anatofuz
parents:
diff changeset
283 if (hasUnstableLinkage(D) || D->getLinkageInternal() < ExternalLinkage)
anatofuz
parents:
diff changeset
284 return SymbolRelevanceSignals::FileScope;
anatofuz
parents:
diff changeset
285 return SymbolRelevanceSignals::GlobalScope;
anatofuz
parents:
diff changeset
286 }
anatofuz
parents:
diff changeset
287
anatofuz
parents:
diff changeset
288 void SymbolRelevanceSignals::merge(const Symbol &IndexResult) {
anatofuz
parents:
diff changeset
289 SymbolURI = IndexResult.CanonicalDeclaration.FileURI;
anatofuz
parents:
diff changeset
290 SymbolScope = IndexResult.Scope;
anatofuz
parents:
diff changeset
291 IsInstanceMember |= isInstanceMember(IndexResult.SymInfo);
anatofuz
parents:
diff changeset
292 if (!(IndexResult.Flags & Symbol::VisibleOutsideFile)) {
anatofuz
parents:
diff changeset
293 Scope = AccessibleScope::FileScope;
anatofuz
parents:
diff changeset
294 }
anatofuz
parents:
diff changeset
295 }
anatofuz
parents:
diff changeset
296
anatofuz
parents:
diff changeset
297 void SymbolRelevanceSignals::merge(const CodeCompletionResult &SemaCCResult) {
anatofuz
parents:
diff changeset
298 if (SemaCCResult.Availability == CXAvailability_NotAvailable ||
anatofuz
parents:
diff changeset
299 SemaCCResult.Availability == CXAvailability_NotAccessible)
anatofuz
parents:
diff changeset
300 Forbidden = true;
anatofuz
parents:
diff changeset
301
anatofuz
parents:
diff changeset
302 if (SemaCCResult.Declaration) {
anatofuz
parents:
diff changeset
303 SemaSaysInScope = true;
anatofuz
parents:
diff changeset
304 // We boost things that have decls in the main file. We give a fixed score
anatofuz
parents:
diff changeset
305 // for all other declarations in sema as they are already included in the
anatofuz
parents:
diff changeset
306 // translation unit.
anatofuz
parents:
diff changeset
307 float DeclProximity = (hasDeclInMainFile(*SemaCCResult.Declaration) ||
anatofuz
parents:
diff changeset
308 hasUsingDeclInMainFile(SemaCCResult))
anatofuz
parents:
diff changeset
309 ? 1.0
anatofuz
parents:
diff changeset
310 : 0.6;
anatofuz
parents:
diff changeset
311 SemaFileProximityScore = std::max(DeclProximity, SemaFileProximityScore);
anatofuz
parents:
diff changeset
312 IsInstanceMember |= isInstanceMember(SemaCCResult.Declaration);
anatofuz
parents:
diff changeset
313 InBaseClass |= SemaCCResult.InBaseClass;
anatofuz
parents:
diff changeset
314 }
anatofuz
parents:
diff changeset
315
anatofuz
parents:
diff changeset
316 // Declarations are scoped, others (like macros) are assumed global.
anatofuz
parents:
diff changeset
317 if (SemaCCResult.Declaration)
anatofuz
parents:
diff changeset
318 Scope = std::min(Scope, computeScope(SemaCCResult.Declaration));
anatofuz
parents:
diff changeset
319
anatofuz
parents:
diff changeset
320 NeedsFixIts = !SemaCCResult.FixIts.empty();
anatofuz
parents:
diff changeset
321 }
anatofuz
parents:
diff changeset
322
anatofuz
parents:
diff changeset
323 static std::pair<float, unsigned> uriProximity(llvm::StringRef SymbolURI,
anatofuz
parents:
diff changeset
324 URIDistance *D) {
anatofuz
parents:
diff changeset
325 if (!D || SymbolURI.empty())
anatofuz
parents:
diff changeset
326 return {0.f, 0u};
anatofuz
parents:
diff changeset
327 unsigned Distance = D->distance(SymbolURI);
anatofuz
parents:
diff changeset
328 // Assume approximately default options are used for sensible scoring.
anatofuz
parents:
diff changeset
329 return {std::exp(Distance * -0.4f / FileDistanceOptions().UpCost), Distance};
anatofuz
parents:
diff changeset
330 }
anatofuz
parents:
diff changeset
331
anatofuz
parents:
diff changeset
332 static float scopeBoost(ScopeDistance &Distance,
anatofuz
parents:
diff changeset
333 llvm::Optional<llvm::StringRef> SymbolScope) {
anatofuz
parents:
diff changeset
334 if (!SymbolScope)
anatofuz
parents:
diff changeset
335 return 1;
anatofuz
parents:
diff changeset
336 auto D = Distance.distance(*SymbolScope);
anatofuz
parents:
diff changeset
337 if (D == FileDistance::Unreachable)
anatofuz
parents:
diff changeset
338 return 0.6f;
anatofuz
parents:
diff changeset
339 return std::max(0.65, 2.0 * std::pow(0.6, D / 2.0));
anatofuz
parents:
diff changeset
340 }
anatofuz
parents:
diff changeset
341
anatofuz
parents:
diff changeset
342 static llvm::Optional<llvm::StringRef>
anatofuz
parents:
diff changeset
343 wordMatching(llvm::StringRef Name, const llvm::StringSet<> *ContextWords) {
anatofuz
parents:
diff changeset
344 if (ContextWords)
anatofuz
parents:
diff changeset
345 for (const auto& Word : ContextWords->keys())
anatofuz
parents:
diff changeset
346 if (Name.contains_lower(Word))
anatofuz
parents:
diff changeset
347 return Word;
anatofuz
parents:
diff changeset
348 return llvm::None;
anatofuz
parents:
diff changeset
349 }
anatofuz
parents:
diff changeset
350
anatofuz
parents:
diff changeset
351 float SymbolRelevanceSignals::evaluate() const {
anatofuz
parents:
diff changeset
352 float Score = 1;
anatofuz
parents:
diff changeset
353
anatofuz
parents:
diff changeset
354 if (Forbidden)
anatofuz
parents:
diff changeset
355 return 0;
anatofuz
parents:
diff changeset
356
anatofuz
parents:
diff changeset
357 Score *= NameMatch;
anatofuz
parents:
diff changeset
358
anatofuz
parents:
diff changeset
359 // File proximity scores are [0,1] and we translate them into a multiplier in
anatofuz
parents:
diff changeset
360 // the range from 1 to 3.
anatofuz
parents:
diff changeset
361 Score *= 1 + 2 * std::max(uriProximity(SymbolURI, FileProximityMatch).first,
anatofuz
parents:
diff changeset
362 SemaFileProximityScore);
anatofuz
parents:
diff changeset
363
anatofuz
parents:
diff changeset
364 if (ScopeProximityMatch)
anatofuz
parents:
diff changeset
365 // Use a constant scope boost for sema results, as scopes of sema results
anatofuz
parents:
diff changeset
366 // can be tricky (e.g. class/function scope). Set to the max boost as we
anatofuz
parents:
diff changeset
367 // don't load top-level symbols from the preamble and sema results are
anatofuz
parents:
diff changeset
368 // always in the accessible scope.
anatofuz
parents:
diff changeset
369 Score *=
anatofuz
parents:
diff changeset
370 SemaSaysInScope ? 2.0 : scopeBoost(*ScopeProximityMatch, SymbolScope);
anatofuz
parents:
diff changeset
371
anatofuz
parents:
diff changeset
372 if (wordMatching(Name, ContextWords))
anatofuz
parents:
diff changeset
373 Score *= 1.5;
anatofuz
parents:
diff changeset
374
anatofuz
parents:
diff changeset
375 // Symbols like local variables may only be referenced within their scope.
anatofuz
parents:
diff changeset
376 // Conversely if we're in that scope, it's likely we'll reference them.
anatofuz
parents:
diff changeset
377 if (Query == CodeComplete) {
anatofuz
parents:
diff changeset
378 // The narrower the scope where a symbol is visible, the more likely it is
anatofuz
parents:
diff changeset
379 // to be relevant when it is available.
anatofuz
parents:
diff changeset
380 switch (Scope) {
anatofuz
parents:
diff changeset
381 case GlobalScope:
anatofuz
parents:
diff changeset
382 break;
anatofuz
parents:
diff changeset
383 case FileScope:
anatofuz
parents:
diff changeset
384 Score *= 1.5f;
anatofuz
parents:
diff changeset
385 break;
anatofuz
parents:
diff changeset
386 case ClassScope:
anatofuz
parents:
diff changeset
387 Score *= 2;
anatofuz
parents:
diff changeset
388 break;
anatofuz
parents:
diff changeset
389 case FunctionScope:
anatofuz
parents:
diff changeset
390 Score *= 4;
anatofuz
parents:
diff changeset
391 break;
anatofuz
parents:
diff changeset
392 }
anatofuz
parents:
diff changeset
393 } else {
anatofuz
parents:
diff changeset
394 // For non-completion queries, the wider the scope where a symbol is
anatofuz
parents:
diff changeset
395 // visible, the more likely it is to be relevant.
anatofuz
parents:
diff changeset
396 switch (Scope) {
anatofuz
parents:
diff changeset
397 case GlobalScope:
anatofuz
parents:
diff changeset
398 break;
anatofuz
parents:
diff changeset
399 case FileScope:
anatofuz
parents:
diff changeset
400 Score *= 0.5f;
anatofuz
parents:
diff changeset
401 break;
anatofuz
parents:
diff changeset
402 default:
anatofuz
parents:
diff changeset
403 // TODO: Handle other scopes as we start to use them for index results.
anatofuz
parents:
diff changeset
404 break;
anatofuz
parents:
diff changeset
405 }
anatofuz
parents:
diff changeset
406 }
anatofuz
parents:
diff changeset
407
anatofuz
parents:
diff changeset
408 if (TypeMatchesPreferred)
anatofuz
parents:
diff changeset
409 Score *= 5.0;
anatofuz
parents:
diff changeset
410
anatofuz
parents:
diff changeset
411 // Penalize non-instance members when they are accessed via a class instance.
anatofuz
parents:
diff changeset
412 if (!IsInstanceMember &&
anatofuz
parents:
diff changeset
413 (Context == CodeCompletionContext::CCC_DotMemberAccess ||
anatofuz
parents:
diff changeset
414 Context == CodeCompletionContext::CCC_ArrowMemberAccess)) {
anatofuz
parents:
diff changeset
415 Score *= 0.2f;
anatofuz
parents:
diff changeset
416 }
anatofuz
parents:
diff changeset
417
anatofuz
parents:
diff changeset
418 if (InBaseClass)
anatofuz
parents:
diff changeset
419 Score *= 0.5f;
anatofuz
parents:
diff changeset
420
anatofuz
parents:
diff changeset
421 // Penalize for FixIts.
anatofuz
parents:
diff changeset
422 if (NeedsFixIts)
anatofuz
parents:
diff changeset
423 Score *= 0.5f;
anatofuz
parents:
diff changeset
424
anatofuz
parents:
diff changeset
425 return Score;
anatofuz
parents:
diff changeset
426 }
anatofuz
parents:
diff changeset
427
anatofuz
parents:
diff changeset
428 llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
anatofuz
parents:
diff changeset
429 const SymbolRelevanceSignals &S) {
anatofuz
parents:
diff changeset
430 OS << llvm::formatv("=== Symbol relevance: {0}\n", S.evaluate());
anatofuz
parents:
diff changeset
431 OS << llvm::formatv("\tName: {0}\n", S.Name);
anatofuz
parents:
diff changeset
432 OS << llvm::formatv("\tName match: {0}\n", S.NameMatch);
anatofuz
parents:
diff changeset
433 if (S.ContextWords)
anatofuz
parents:
diff changeset
434 OS << llvm::formatv(
anatofuz
parents:
diff changeset
435 "\tMatching context word: {0}\n",
anatofuz
parents:
diff changeset
436 wordMatching(S.Name, S.ContextWords).getValueOr("<none>"));
anatofuz
parents:
diff changeset
437 OS << llvm::formatv("\tForbidden: {0}\n", S.Forbidden);
anatofuz
parents:
diff changeset
438 OS << llvm::formatv("\tNeedsFixIts: {0}\n", S.NeedsFixIts);
anatofuz
parents:
diff changeset
439 OS << llvm::formatv("\tIsInstanceMember: {0}\n", S.IsInstanceMember);
anatofuz
parents:
diff changeset
440 OS << llvm::formatv("\tContext: {0}\n", getCompletionKindString(S.Context));
anatofuz
parents:
diff changeset
441 OS << llvm::formatv("\tQuery type: {0}\n", static_cast<int>(S.Query));
anatofuz
parents:
diff changeset
442 OS << llvm::formatv("\tScope: {0}\n", static_cast<int>(S.Scope));
anatofuz
parents:
diff changeset
443
anatofuz
parents:
diff changeset
444 OS << llvm::formatv("\tSymbol URI: {0}\n", S.SymbolURI);
anatofuz
parents:
diff changeset
445 OS << llvm::formatv("\tSymbol scope: {0}\n",
anatofuz
parents:
diff changeset
446 S.SymbolScope ? *S.SymbolScope : "<None>");
anatofuz
parents:
diff changeset
447
anatofuz
parents:
diff changeset
448 if (S.FileProximityMatch) {
anatofuz
parents:
diff changeset
449 auto Score = uriProximity(S.SymbolURI, S.FileProximityMatch);
anatofuz
parents:
diff changeset
450 OS << llvm::formatv("\tIndex URI proximity: {0} (distance={1})\n",
anatofuz
parents:
diff changeset
451 Score.first, Score.second);
anatofuz
parents:
diff changeset
452 }
anatofuz
parents:
diff changeset
453 OS << llvm::formatv("\tSema file proximity: {0}\n", S.SemaFileProximityScore);
anatofuz
parents:
diff changeset
454
anatofuz
parents:
diff changeset
455 OS << llvm::formatv("\tSema says in scope: {0}\n", S.SemaSaysInScope);
anatofuz
parents:
diff changeset
456 if (S.ScopeProximityMatch)
anatofuz
parents:
diff changeset
457 OS << llvm::formatv("\tIndex scope boost: {0}\n",
anatofuz
parents:
diff changeset
458 scopeBoost(*S.ScopeProximityMatch, S.SymbolScope));
anatofuz
parents:
diff changeset
459
anatofuz
parents:
diff changeset
460 OS << llvm::formatv(
anatofuz
parents:
diff changeset
461 "\tType matched preferred: {0} (Context type: {1}, Symbol type: {2}\n",
anatofuz
parents:
diff changeset
462 S.TypeMatchesPreferred, S.HadContextType, S.HadSymbolType);
anatofuz
parents:
diff changeset
463
anatofuz
parents:
diff changeset
464 return OS;
anatofuz
parents:
diff changeset
465 }
anatofuz
parents:
diff changeset
466
anatofuz
parents:
diff changeset
467 float evaluateSymbolAndRelevance(float SymbolQuality, float SymbolRelevance) {
anatofuz
parents:
diff changeset
468 return SymbolQuality * SymbolRelevance;
anatofuz
parents:
diff changeset
469 }
anatofuz
parents:
diff changeset
470
anatofuz
parents:
diff changeset
471 // Produces an integer that sorts in the same order as F.
anatofuz
parents:
diff changeset
472 // That is: a < b <==> encodeFloat(a) < encodeFloat(b).
anatofuz
parents:
diff changeset
473 static uint32_t encodeFloat(float F) {
anatofuz
parents:
diff changeset
474 static_assert(std::numeric_limits<float>::is_iec559, "");
anatofuz
parents:
diff changeset
475 constexpr uint32_t TopBit = ~(~uint32_t{0} >> 1);
anatofuz
parents:
diff changeset
476
anatofuz
parents:
diff changeset
477 // Get the bits of the float. Endianness is the same as for integers.
anatofuz
parents:
diff changeset
478 uint32_t U = llvm::FloatToBits(F);
anatofuz
parents:
diff changeset
479 // IEEE 754 floats compare like sign-magnitude integers.
anatofuz
parents:
diff changeset
480 if (U & TopBit) // Negative float.
anatofuz
parents:
diff changeset
481 return 0 - U; // Map onto the low half of integers, order reversed.
anatofuz
parents:
diff changeset
482 return U + TopBit; // Positive floats map onto the high half of integers.
anatofuz
parents:
diff changeset
483 }
anatofuz
parents:
diff changeset
484
anatofuz
parents:
diff changeset
485 std::string sortText(float Score, llvm::StringRef Name) {
anatofuz
parents:
diff changeset
486 // We convert -Score to an integer, and hex-encode for readability.
anatofuz
parents:
diff changeset
487 // Example: [0.5, "foo"] -> "41000000foo"
anatofuz
parents:
diff changeset
488 std::string S;
anatofuz
parents:
diff changeset
489 llvm::raw_string_ostream OS(S);
anatofuz
parents:
diff changeset
490 llvm::write_hex(OS, encodeFloat(-Score), llvm::HexPrintStyle::Lower,
anatofuz
parents:
diff changeset
491 /*Width=*/2 * sizeof(Score));
anatofuz
parents:
diff changeset
492 OS << Name;
anatofuz
parents:
diff changeset
493 OS.flush();
anatofuz
parents:
diff changeset
494 return S;
anatofuz
parents:
diff changeset
495 }
anatofuz
parents:
diff changeset
496
anatofuz
parents:
diff changeset
497 llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
anatofuz
parents:
diff changeset
498 const SignatureQualitySignals &S) {
anatofuz
parents:
diff changeset
499 OS << llvm::formatv("=== Signature Quality:\n");
anatofuz
parents:
diff changeset
500 OS << llvm::formatv("\tNumber of parameters: {0}\n", S.NumberOfParameters);
anatofuz
parents:
diff changeset
501 OS << llvm::formatv("\tNumber of optional parameters: {0}\n",
anatofuz
parents:
diff changeset
502 S.NumberOfOptionalParameters);
anatofuz
parents:
diff changeset
503 OS << llvm::formatv("\tKind: {0}\n", S.Kind);
anatofuz
parents:
diff changeset
504 return OS;
anatofuz
parents:
diff changeset
505 }
anatofuz
parents:
diff changeset
506
anatofuz
parents:
diff changeset
507 } // namespace clangd
anatofuz
parents:
diff changeset
508 } // namespace clang